Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): Madara configuration via environment variables #311

Merged
merged 5 commits into from
Oct 8, 2024
Merged

feat(cli): Madara configuration via environment variables #311

merged 5 commits into from
Oct 8, 2024

Conversation

shamsasari
Copy link
Contributor

They are specified with the prefix MADARA_ followed by the command-line argument in screaming snake case.

This is part of #285.

@shamsasari
feat(cli): Madara configuration via environment variables
5b3cd54 
They are specified with the prefix `MADARA_` followed by the command-line argument in screaming snake case.

This is part of #285.
@shamsasari shamsasari mentioned this pull request Oct 4, 2024
Open
1 task
@Trantorian1 Trantorian1 requested a review from antiyro October 7, 2024 06:26
@Trantorian1 Trantorian1 self-requested a review October 7, 2024 06:27
@Trantorian1 Trantorian1 added the feature Request for new feature or enhancement label Oct 7, 2024
@Trantorian1
Copy link
Collaborator

Added a quick warning about setting secrets like MADARA_L1_ENDPOINT or MADARA_GATEWAY_KEY in env. Going forwards (especially considering the support for configuration files in #285) we might want to come up with some better way to have users provide secrets in a safe, isolated way.

Trantorian1
Trantorian1 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

antiyro
antiyro reviewed Oct 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
crates/node/src/cli/block_production.rs Outdated Show resolved Hide resolved
crates/node/src/cli/block_production.rs Outdated Show resolved Hide resolved
@antiyro
Copy link
Member

antiyro commented Oct 7, 2024

apart from the typos that are not introduced by you but would be great fixing lgmt!

@shamsasari
Copy link
Contributor Author

Typos fixed.

@Trantorian1 Trantorian1 requested a review from antiyro October 8, 2024 06:25
antiyro
antiyro approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antiyro antiyro merged commit 9414233 into main Oct 8, 2024
10 checks passed
@shamsasari shamsasari deleted the shams-env-config branch October 8, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trantorian1 Trantorian1 Trantorian1 approved these changes

@antiyro antiyro antiyro approved these changes

Assignees

@shamsasari shamsasari

Labels
feature Request for new feature or enhancement
Projects
Madara
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamsasari @Trantorian1 @antiyro