Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override cli #312

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: override cli #312

merged 2 commits into from
Oct 8, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Oct 7, 2024

Pull Request type

  • Bugfix

What is the current behavior?

Resolves: #297

What is the new behavior?

  • add default versioned_constants
  • fix: override_chain_config

Does this introduce a breaking change?

No

Other information

@jbcaron jbcaron added the sequencer Related to the sequencing logic and implementation label Oct 7, 2024
@jbcaron jbcaron self-assigned this Oct 7, 2024
@jbcaron jbcaron marked this pull request as ready for review October 7, 2024 08:22
@jbcaron jbcaron force-pushed the feat/cli-override branch 3 times, most recently from 020bced to cfe8f5c Compare October 7, 2024 09:56
@jbcaron jbcaron force-pushed the feat/cli-override branch from cfe8f5c to fdea972 Compare October 7, 2024 18:10
@jbcaron jbcaron requested a review from Trantorian1 October 7, 2024 18:11
@jbcaron jbcaron force-pushed the feat/cli-override branch from fdea972 to e3141fc Compare October 7, 2024 19:20
@jbcaron jbcaron requested a review from akhercha October 8, 2024 05:47
@jbcaron jbcaron force-pushed the feat/cli-override branch from e3141fc to 8a2f867 Compare October 8, 2024 12:10
configs/presets/integration.yaml Show resolved Hide resolved
configs/presets/mainnet.yaml Show resolved Hide resolved
configs/presets/sepolia.yaml Show resolved Hide resolved
Copy link
Member

@akhercha akhercha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@antiyro antiyro merged commit 66543dd into main Oct 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer Related to the sequencing logic and implementation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(config): Add support for nested chain config override
3 participants