Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rust log filtering #397

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix/rust log filtering #397

merged 2 commits into from
Nov 27, 2024

Conversation

heemankv
Copy link
Contributor

Filtering based on RUST_LOG stopped working after adding log-level as a clap argument.
removed log_level from clap to get it and added code to pick RUST_LOG from env directly.

@heemankv heemankv self-assigned this Nov 26, 2024
Copy link
Contributor Author

@heemankv heemankv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review completed, looks fine to me

Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@antiyro antiyro merged commit de271ba into main Nov 27, 2024
10 checks passed
@heemankv heemankv deleted the fix/rust_log_filtering branch November 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants