fix(block_production): continue pending block now reexecutes the previous transactions #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious transactions
|
note: the file change count is 45 which seems like a lot, but most files have a 1-line change. I don't believe this is a large PR |
jbcaron
added
bug
jbcaron
approved these changes
Dec 12, 2024
Comment on lines
+115
to
+117
| /// Get class info + sierra compiled when it's a sierra class. | ||
| // Note/TODO: "ConvertedClass" is the name of the type that has info + sierra compiled, and it is used for blockifier | ||
| // convertion & storage. We should rename it, as this feels like undecipherable madara-specific jargon at this point. |
There was a problem hiding this comment.
We could rename it to ResolvedClass or CanonicalClass
| @@ -26,53 +26,26 @@ pub enum Error { | |||
| /// | |||
| /// **note:** this function does not support deploy transaction | |||
| /// because it is not supported by blockifier | |||
| pub fn to_blockifier_transactions( | |||
| pub fn to_blockifier_transaction( | |||
Trantorian1
requested changes
Dec 13, 2024
antiyro
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
We had a hacky way of continuing the pending block state on restart.
What is the new behavior?
Now, we re-add all the transactions from the pending block into the mempool when restarting with a priority.
I also did some refactoring here and there:
Does this introduce a breaking change?
No, db remains unchanged.