refactor(gateway): user transaction improvements - hex serialization & query-only removal #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcaron
changed the title
tip as hex in UserTransaction
antiyro
approved these changes
Dec 20, 2024
jbcaron
force-pushed
the
fix/fgw-user-transaction
branch
from
3dd1a16 to
1e78f22
Compare
jbcaron
force-pushed
the
fix/fgw-user-transaction
branch
from
1e78f22 to
539063c
Compare
cchudant
reviewed
Jan 9, 2025
| let string_reader = std::io::Cursor::new(compressed_sierra_class.sierra_program); | ||
| let base64_decoder = | ||
| base64::read::DecoderReader::new(string_reader, &base64::engine::general_purpose::STANDARD); | ||
| let gzip_decoder = flate2::read::GzDecoder::new(base64_decoder); |
There was a problem hiding this comment.
aaaaaah
you should look at
#459
also I had no idea compressed sierra was a thing? i thought only legacy classes were compressed
that's new right?
Trantorian1
requested changes
Jan 10, 2025
Trantorian1
approved these changes
Jan 14, 2025
Comment on lines
+61
to
+68
| /// Marker trait to restrict which types can be used as transaction results. | ||
| /// Only valid Starknet transaction responses implement this trait. | ||
| pub trait ValidTransactionResult {} | ||
|
|
||
| // Implement the marker trait for the three valid transaction result types | ||
| impl<T> ValidTransactionResult for AddInvokeTransactionResult<T> {} | ||
| impl<T> ValidTransactionResult for AddDeclareTransactionResult<T> {} | ||
| impl<T> ValidTransactionResult for AddDeployAccountTransactionResult<T> {} |
There was a problem hiding this comment.
Consider sealing this trait by either making it private if does not need to be accessed outside of this crate, or a sub-trait of a private trait if it does.
Suggested change
| /// Marker trait to restrict which types can be used as transaction results. | |
| /// Only valid Starknet transaction responses implement this trait. | |
| pub trait ValidTransactionResult {} | |
| // Implement the marker trait for the three valid transaction result types | |
| impl<T> ValidTransactionResult for AddInvokeTransactionResult<T> {} | |
| impl<T> ValidTransactionResult for AddDeclareTransactionResult<T> {} | |
| impl<T> ValidTransactionResult for AddDeployAccountTransactionResult<T> {} | |
| /// Ensures [ValidTransactionResult] is accessible from outside the crate but cannot be implemented on any new structs | |
| trait Sealed {} | |
| /// Marker trait to restrict which types can be used as transaction results. | |
| /// Only valid Starknet transaction responses implement this trait. | |
| pub trait ValidTransactionResult: Sealed {} | |
| // Implement the marker trait for the three valid transaction result types | |
| impl<T> Sealed for AddInvokeTransactionResult<T> {} | |
| impl<T> Sealed for AddDeclareTransactionResult<T> {} | |
| impl<T> Sealed for AddDeployAccountTransactionResult<T> {} | |
| impl<T> ValidTransactionResult for AddInvokeTransactionResult<T> {} | |
| impl<T> ValidTransactionResult for AddDeclareTransactionResult<T> {} | |
| impl<T> ValidTransactionResult for AddDeployAccountTransactionResult<T> {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
Yes: gateway API
Other information