fix(rpc): call, simulate, estimate rpcs executed on top of the block, not at the start of it #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchudant
force-pushed
the
fix-rpc-exec-on-top-of-block
branch
2 times, most recently
from
d26d5ce to
8b42c0a
Compare
jbcaron
approved these changes
Dec 23, 2024
Trantorian1
added
bug
… not at the start of it
jbcaron
force-pushed
the
fix-rpc-exec-on-top-of-block
branch
from
8b42c0a to
6291a93
Compare
|
Could you fix the CI @cchudant ? |
antiyro
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Call, simulate, estimate rpcs are now executed on top of the block they request instead of at the start of it.
What is the new behavior?
State changes that happen during the block requested in these rpc calls are now visible to the execution.
Trace block and trance transaction rpcs are unchanged - state changed during the block shouldn't be visible to these as they reexecute the requested block.
Does this introduce a breaking change?
No