Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): migrated changelog action on releases for conventional commits only #446

Merged
merged 3 commits into from
Jan 3, 2025
+9 −22
Merged

fix(ci): migrated changelog action on releases for conventional commits only #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17a6c10
fix(ci): migrated changelog action on releases for conventional commi…
antiyro Dec 30, 2024
2871c67
cleaned codebase
antiyro Dec 30, 2024
9538f6c
cleaned body
antiyro Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/workflows/changelog.yml
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,15 @@ permissions:
pull-requests: write

jobs:
changelog:
name: Enforce CHANGELOG
if: github.event.pull_request.draft == false
uses: ./.github/workflows/changelog.yml

linters:
name: Run linters
if: github.event.pull_request.draft == false
uses: ./.github/workflows/linters.yml
needs: changelog

rust_check:
name: Run check
if: github.event.pull_request.draft == false
uses: ./.github/workflows/rust-check.yml
needs: changelog

linters_cargo:
name: Run Cargo linters
Expand All @@ -41,13 +34,11 @@ jobs:
name: Run Coverage
if: github.event.pull_request.draft == false
uses: ./.github/workflows/coverage.yml
needs: changelog
secrets: inherit

build:
name: Build Madara
uses: ./.github/workflows/build.yml
needs: changelog

js_test:
name: Run JS Tests
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Generate Release Notes
id: generate_notes
uses: conventional-changelog/releaser-action@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just linking this issue for completeness sake, touch I don't think it should affect us: TriPSs/conventional-changelog-action#239

with:
preset: "angular"

- name: Create GitHub Release
uses: ncipollo/release-action@v1
Expand All @@ -26,4 +34,4 @@ jobs:
commit: ${{ github.sha }}
draft: false
prerelease: false
generateReleaseNotes: true
body: ${{ steps.generate_notes.outputs.notes }}
Loading