fix(block_production): dynamic block closing #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohiiit
added
bug
Trantorian1
reviewed
Jan 8, 2025
| @@ -358,20 +358,45 @@ impl<Mempool: MempoolProvider> BlockProductionTask<Mempool> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn maybe_add_prev_block_hash(&self, state_diff: &mut StateDiff, block_n: u64) -> Result<(), Error> { | |||
There was a problem hiding this comment.
Maybe add a doc comment to this function explaining why this is needed and what it does.
jbcaron
reviewed
Jan 8, 2025
| @@ -358,20 +358,45 @@ impl<Mempool: MempoolProvider> BlockProductionTask<Mempool> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn maybe_add_prev_block_hash(&self, state_diff: &mut StateDiff, block_n: u64) -> Result<(), Error> { | |||
There was a problem hiding this comment.
The current name maybe_add_prev_block_hash is somewhat ambiguous and doesn't fully capture the function's role in the state management process.
There was a problem hiding this comment.
does it make more sense now? or any suggestion what can be improved?
jbcaron
approved these changes
Jan 8, 2025
jbcaron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that madara correctly adds a special address to the state diff when dynamically closing a block with a number greater than 10. The special address uses the current block number minus 10 as the key and the hash of (current block - 10) as the value. This is required for the SNOS.
Pull Request Type
Current Behavior
When the bouncer configuration reaches its limit, Madara dynamically closes the block. However, during this process, the required special address is not added to the state diff for blocks numbered greater than 10.
New Behavior
When closing a block dynamically, if the block number is greater than 10, a special address is now correctly added to the state diff with:
Breaking Changes
No breaking changes introduced.
Additional Notes
This fix ensures consistency in state diffs when dynamic block closing occurs, maintaining expected behavior for blocks greater than 10.