JPA 엔티티를 구현한다. #170
Merged
JPA 엔티티를 구현한다. #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Results60 tests 60 ✅ 2s ⏱️ Results for commit 6aaaf53. |
kunsanglee
reviewed
Jan 20, 2025
| return Arrays.stream(WikiCategory.values()) | ||
| .filter(it -> it.name().equalsIgnoreCase(category)) | ||
| .findFirst() | ||
| .orElseThrow(IllegalArgumentException::new); |
There was a problem hiding this comment.
Provider에서는 NoSuchElementException 던졌는데 통일되면 좋을 것 같아요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommentLike엔티티의 type 컬럼은 기획의 구체화가 필요하므로 본 PR에서 제외합니다.