-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
인증 및 회원가입 기능을 구현한다. #179
Merged
인증 및 회원가입 기능을 구현한다. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
le2sky
commented
Jan 23, 2025
•
edited
Loading
edited
- close 인증 및 회원가입 기능을 구현한다. #178
- 회원 인증 및 회원 가입 기능을 구현했어요.
- 기존재 회원의 요청이라면, 인증으로 판단하여 토큰을 갱신합니다.
- 신규 회원의 요청이라면, 회원가입 및 인증으로 판단하여 회원을 등록하고 토큰을 설정해요.
- 토큰은 jjwt 라이브러리를 사용했어요. java-jwt 랑 비교해서 버전이 낮다는 점이 마음에 걸렸지만, 근래에도 활발히 유지보수가 진행된다는 점이 결정 근거였어요.
- jwt에 사용한 알고리즘은 jjwt 디펄트 알고리즘인 HS256을 사용했습니다.
- 해당 요청에 clientSecret이 필요한 이유는 서버에서 accessToken만 받는 경우, 발생할 수 있는 비정상 케이스를 예방하기 위함이에요.
- 외부 oauth 로그인으로 accessToken을 얻거나, developer setting으로 accessToken을 생성한다.
- 직접 서버로 accessToken만 포함한 요청을 보낸다.
- 회원 가입이 성공한다.
Test Results79 tests 78 ✅ 4s ⏱️ Results for commit 59cde26. ♻️ This comment has been updated with latest results. |
- jjwt 의존성을 추가했다. - configuration processor 의존성을 추가했다.
- 명시적으로 엔티티 매핑을 수행했다. - refreshToken 컬럼을 추가했다. - 주생성자를 변경했다.
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.