Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storefront properties for Product Attributes #490

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Storefront properties for Product Attributes #490

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f873651
Add Storefront properties for Product Attributes
prabhuram93 May 6, 2021
0294d2c
Update EavGraphQl.graphqls
prabhuram93 May 10, 2021
a9e590e
Updated based on review comments
prabhuram93 May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion design-documents/graph-ql/coverage/eav/EavGraphQl.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ type StorefrontProperties {
position: Int
visible_on_catalog_storefront: Boolean
use_in_layered_navigation: UseInLayeredNavigationOptions
use_in_search_results_layered_navigation: Boolean
use_in_search: Boolean
Copy link

@supernova-at supernova-at May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs to be included. The way I understand it, this is more for y'all or the search team. If Use in Search is set to YES, then users can search by the product attribute values (ex: "Green"), and matching products will be included in the result set.

Venia won't do anything with this setting.

}

enum UseInLayeredNavigationOptions {
NO
FILTERABLE_WTH_RESULTS
FILTERABLE_WITH_RESULTS
FILTERABLE_NO_RESULT
}

Expand All @@ -40,3 +42,8 @@ input AttributeInput @doc(description: "AttributeInput specifies the attribute_c
attribute_code: String @doc(description: "The unique identifier for an attribute code. This value should be in lowercase letters without spaces.")
entity_type: String @doc(description: "The type of entity that defines the attribute")
}

# Additional changes made in CatalogGraphQl schema
type Aggregation @doc(description: "A bucket that contains information for each filterable option (such as price, category `UID`, and custom attributes).") {
position: Int @doc(description: "The position of attribute in layered navigation block.")
}