Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laminas\Stdlib for glob compatibility #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phoenix-bjoern
Copy link

@phoenix-bjoern phoenix-bjoern commented Jun 3, 2022

On Linux distributions like Alpine GLOB_BRACE is not available, which is a known issue.

An elegant workaround is to use Laminas\Stdlib instead of PHP's native glob() function. Will create a PR which hopefully gets accepted to solve this annoying issue.

@gwharton
Copy link

gwharton commented Jun 22, 2022

Oh yes please. Can we have this merged and released.

@linshin
Copy link

linshin commented Aug 12, 2022

Is this going to get merged anytime soon?

@leonhelmus
Copy link

@magento-admin Please merge this. It now gives us an error whenever we want to do a composer install!

@woutk88
Copy link

woutk88 commented Aug 17, 2022

Experiencing the same issue, would like to see this get merged and released.

@hostep
Copy link

hostep commented Aug 17, 2022

@sidolov: maybe the open PR's in this repo should be taken a look at? It seems like they are being forgotten 🙂

@RPrudon
Copy link

RPrudon commented Aug 17, 2022

I have the same issue.

@Epo123
Copy link

Epo123 commented Aug 17, 2022

Please merge this, we have the same issue.

@phoenix-bjoern
Copy link
Author

@fascinosum can you chime in here?

@fascinosum
Copy link
Collaborator

@xmav could you help with this?

@xmav
Copy link

xmav commented Aug 19, 2022

@phoenix-bjoern
Copy link
Author

@xmav updated PR has been created as requested.

@karbowiak
Copy link

Any movement on this? Even a beta would be stellar at this point :P

@leonhelmus
Copy link

can this please be merged?

@rimple-saini
Copy link

@phoenix-bjoern Thank you fixing this issue.

It will be taken care into one of the Internal JIRA ticket. Once Internal PR will get merged, we will notify.

Thank you!

CC @Wojton

@guvra
Copy link

guvra commented Nov 22, 2022

Any news?

It's a hassle to work with Magento on alpine containers and the fix was submitted months ago.

@rimple-saini
Copy link

rimple-saini commented Nov 22, 2022

@guvra We have raised the Mainline PR for this issue. It is estimated to be merged soon. Once Internal PR gets merge, we will keep you posted on this.

@rimple-saini
Copy link

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket JIRA ticket by the internal team.

Based on the Jira ticket, the target version is 2.4.6.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.