Add support for Recteq RT700 Grill #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make-all
reviewed
Jan 7, 2025
| @@ -0,0 +1,42 @@ | |||
| name: RecTeq RT-700 Grill | |||
| products: | |||
| - id: 5518137548fda419c2e | |||
There was a problem hiding this comment.
This appears to be a device id rather than product id.
| dps: | ||
| - id: 1 | ||
| type: boolean | ||
| mapping: |
There was a problem hiding this comment.
name is required, was the removal of name: hvac_mode accidental?
- combined primary and secondary entities into a single list - split product name into components Other review changes: - Remove branding from top level name - add icon to climate entity PR make-all#2741
In absense of an explanation, revert the removal of name to make the config valid again. PR make-all#2741
Since there has been no reply, go to merge without a product id. PR make-all#2741
make-all
added a commit
that referenced
this pull request
Feb 4, 2025
- combined primary and secondary entities into a single list - split product name into components Other review changes: - Remove branding from top level name - add icon to climate entity PR #2741
make-all
added a commit
that referenced
this pull request
Feb 4, 2025
In absense of an explanation, revert the removal of name to make the config valid again. PR #2741
make-all
added a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.