Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AWS role #817

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Use AWS role #817

merged 3 commits into from
Jun 14, 2024

Conversation

jeannettemcd
Copy link
Contributor

Change GHA deploy workflow to use AWS role.

sanbotto
sanbotto approved these changes Jun 13, 2024
View reviewed changes
Copy link

@sanbotto sanbotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if it's necessary, but I'd change the role-session-name to something specific to each workflow, in case there could be issues with reusing the session name when 2 workflows are running at the same time.

@jeannettemcd jeannettemcd merged commit 5cadc8a into develop Jun 14, 2024
1 check passed
@jeannettemcd jeannettemcd deleted the TECH-3250-set-role branch June 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbotto sanbotto sanbotto approved these changes

@cristidas cristidas cristidas approved these changes

@eskp eskp Awaiting requested review from eskp

@OleksandrUA OleksandrUA Awaiting requested review from OleksandrUA

@nickkounz nickkounz Awaiting requested review from nickkounz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeannettemcd @cristidas @sanbotto