Skip to content
Control Lint

Merge branch 'master' of github.com:makers-for-life/makair-control-ui #824

Sign in to view logs

Merge branch 'master' of github.com:makers-for-life/makair-control-ui

Merge branch 'master' of github.com:makers-for-life/makair-control-ui #824

GitHub Actions / clippy failed Jan 6, 2025 in 5s

clippy

379 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 379
Warning 0
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 140 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
   --> src/widget/telemetry_view.rs:140:9
    |
140 |         unit_text_style.font_id = Some(Some(master.fonts.regular));
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.regular)), color: Some(color::WHITE.with_alpha(0.35)), font_size: Some(TELEMETRY_WIDGET_UNIT_FONT_SIZE), ..Default::default() }` and removing relevant reassignments
   --> src/widget/telemetry_view.rs:138:9
    |
138 |         let mut unit_text_style = conrod_core::widget::primitive::text::Style::default();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 77 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/telemetry_view.rs:77:13
   |
77 |             target_text_style.font_id = Some(Some(master.fonts.regular));
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.regular)), color: Some(color::WHITE), font_size: Some(23), ..Default::default() }` and removing relevant reassignments
  --> src/widget/telemetry_view.rs:75:13
   |
75 |             let mut target_text_style = conrod_core::widget::primitive::text::Style::default();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 66 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/telemetry_view.rs:66:5
   |
66 |     value_text_style.font_id = Some(Some(master.fonts.bold));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(40), ..Default::default() }` and removing relevant reassignments
  --> src/widget/telemetry_view.rs:64:5
   |
64 |     let mut value_text_style = conrod_core::widget::primitive::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 41 in src/widget/stop.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/stop.rs:41:5
   |
41 |     message_style.color = Some(MESSAGE_COLOR);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { color: Some(MESSAGE_COLOR), font_size: Some(14), font_id: Some(Some(master.fonts.regular)), ..Default::default() }` and removing relevant reassignments
  --> src/widget/stop.rs:39:5
   |
39 |     let mut message_style = widget::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 28 in src/widget/stop.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/stop.rs:28:5
   |
28 |     title_style.color = Some(color::WHITE);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { color: Some(color::WHITE), font_size: Some(19), font_id: Some(Some(master.fonts.bold)), ..Default::default() }` and removing relevant reassignments
  --> src/widget/stop.rs:26:5
   |
26 |     let mut title_style = widget::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 140 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
   --> src/widget/telemetry_view.rs:140:9
    |
140 |         unit_text_style.font_id = Some(Some(master.fonts.regular));
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.regular)), color: Some(color::WHITE.with_alpha(0.35)), font_size: Some(TELEMETRY_WIDGET_UNIT_FONT_SIZE), ..Default::default() }` and removing relevant reassignments
   --> src/widget/telemetry_view.rs:138:9
    |
138 |         let mut unit_text_style = conrod_core::widget::primitive::text::Style::default();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 77 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/telemetry_view.rs:77:13
   |
77 |             target_text_style.font_id = Some(Some(master.fonts.regular));
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.regular)), color: Some(color::WHITE), font_size: Some(23), ..Default::default() }` and removing relevant reassignments
  --> src/widget/telemetry_view.rs:75:13
   |
75 |             let mut target_text_style = conrod_core::widget::primitive::text::Style::default();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 66 in src/widget/telemetry_view.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/telemetry_view.rs:66:5
   |
66 |     value_text_style.font_id = Some(Some(master.fonts.bold));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(40), ..Default::default() }` and removing relevant reassignments
  --> src/widget/telemetry_view.rs:64:5
   |
64 |     let mut value_text_style = conrod_core::widget::primitive::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 165 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
   --> src/widget/status.rs:165:5
    |
165 |     power_text_style.font_id = Some(Some(master.fonts.bold));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(11), ..Default::default() }` and removing relevant reassignments
   --> src/widget/status.rs:163:5
    |
163 |     let mut power_text_style = conrod_core::widget::primitive::text::Style::default();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 92 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/status.rs:92:5
   |
92 |     unit_text_style.font_id = Some(Some(master.fonts.bold));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(11), ..Default::default() }` and removing relevant reassignments
  --> src/widget/status.rs:90:5
   |
90 |     let mut unit_text_style = conrod_core::widget::primitive::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 41 in src/widget/stop.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/stop.rs:41:5
   |
41 |     message_style.color = Some(MESSAGE_COLOR);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { color: Some(MESSAGE_COLOR), font_size: Some(14), font_id: Some(Some(master.fonts.regular)), ..Default::default() }` and removing relevant reassignments
  --> src/widget/stop.rs:39:5
   |
39 |     let mut message_style = widget::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 28 in src/widget/stop.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/stop.rs:28:5
   |
28 |     title_style.color = Some(color::WHITE);
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { color: Some(color::WHITE), font_size: Some(19), font_id: Some(Some(master.fonts.bold)), ..Default::default() }` and removing relevant reassignments
  --> src/widget/stop.rs:26:5
   |
26 |     let mut title_style = widget::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 45 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/status.rs:45:15
   |
45 | pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
   |               ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
45 - pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
45 + pub fn render(master: &mut ControlWidget<'_>, config: Config) -> f64 {
   |

Check failure on line 73 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/snooze_settings.rs:73:16
   |
73 | fn alarms_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |                ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
73 - fn alarms_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
73 + fn alarms_form(master: &mut ControlWidget<'_>, config: &Config) {
   |

Check failure on line 61 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/snooze_settings.rs:61:17
   |
61 | fn alarms_label<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |                 ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
61 - fn alarms_label<'a>(master: &mut ControlWidget<'a>, config: &Config) {
61 + fn alarms_label(master: &mut ControlWidget<'_>, config: &Config) {
   |

Check failure on line 58 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/widget/snooze_settings.rs:58:25
   |
58 |     alarms_form(master, &config);
   |                         ^^^^^^^ help: change this to: `config`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 57 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/widget/snooze_settings.rs:57:26
   |
57 |     alarms_label(master, &config);
   |                          ^^^^^^^ help: change this to: `config`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check failure on line 55 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/snooze_settings.rs:55:11
   |
55 | fn alarms<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |           ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
55 - fn alarms<'a>(master: &mut ControlWidget<'a>, config: &Config) {
55 + fn alarms(master: &mut ControlWidget<'_>, config: &Config) {
   |

Check failure on line 165 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
   --> src/widget/status.rs:165:5
    |
165 |     power_text_style.font_id = Some(Some(master.fonts.bold));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(11), ..Default::default() }` and removing relevant reassignments
   --> src/widget/status.rs:163:5
    |
163 |     let mut power_text_style = conrod_core::widget::primitive::text::Style::default();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 92 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field assignment outside of initializer for an instance created with Default::default() 

error: field assignment outside of initializer for an instance created with Default::default()
  --> src/widget/status.rs:92:5
   |
92 |     unit_text_style.font_id = Some(Some(master.fonts.bold));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: consider initializing the variable with `conrod_core::widget::text::Style { font_id: Some(Some(master.fonts.bold)), color: Some(color::WHITE), font_size: Some(11), ..Default::default() }` and removing relevant reassignments
  --> src/widget/status.rs:90:5
   |
90 |     let mut unit_text_style = conrod_core::widget::primitive::text::Style::default();
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

Check failure on line 36 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/snooze_settings.rs:36:15
   |
36 | pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
   |               ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
36 - pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
36 + pub fn render(master: &mut ControlWidget<'_>, config: Config) -> f64 {
   |

Check failure on line 45 in src/widget/status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/status.rs:45:15
   |
45 | pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
   |               ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
45 - pub fn render<'a>(master: &mut ControlWidget<'a>, config: Config) -> f64 {
45 + pub fn render(master: &mut ControlWidget<'_>, config: Config) -> f64 {
   |

Check failure on line 72 in src/widget/run_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/run_settings.rs:72:16
   |
72 | fn status_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |                ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
72 - fn status_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
72 + fn status_form(master: &mut ControlWidget<'_>, config: &Config) {
   |

Check failure on line 73 in src/widget/snooze_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/snooze_settings.rs:73:16
   |
73 | fn alarms_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |                ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
73 - fn alarms_form<'a>(master: &mut ControlWidget<'a>, config: &Config) {
73 + fn alarms_form(master: &mut ControlWidget<'_>, config: &Config) {
   |

Check failure on line 60 in src/widget/run_settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> src/widget/run_settings.rs:60:17
   |
60 | fn status_label<'a>(master: &mut ControlWidget<'a>, config: &Config) {
   |                 ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
60 - fn status_label<'a>(master: &mut ControlWidget<'a>, config: &Config) {
60 + fn status_label(master: &mut ControlWidget<'_>, config: &Config) {
   |
View more details on GitHub Actions