-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement on-the-fly descriptor calculation #630
Implement on-the-fly descriptor calculation #630
Conversation
I just looked into the DDP side of things. The problem here seems to be that DDP allocates the GPU for its own usage, so when LAMMPS wants to use them, they are not free. This should still be solvable, but requires more modification in the code. I will first address the other open issues and address this issue later on, maybe in a separate PR. |
Skipping DDP implementation for now since it is not that crucial at the moment and can be added later. See #631 |
This PR gives MALA the capability to compute descriptors on the fly. In doing so, it allows for more refined hyperparameter optimization of descriptor related hyperparameters, since the training-free methods we initially envisioned may not (yet) be enough in many cases. The starting point for this on-the-fly methods are the .json files the DataConverter class can generate.
Since this is a pretty fundamental change in the MALA pipeline, it requires thorough testing. Namely, the following capabilities have to be implemented:
DDP training:RAM based trainingRAM based training w/ checkpointingLazy loading trainingLazy loading training w/ checkpointing