Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create directories from envs_dirs if they do not exist #3796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

holzman
Copy link

@holzman holzman commented Feb 4, 2025

Fixes #3790

@jjerphan jjerphan changed the title Create directory from envs_dirs if it does not exist fix: Create directories from envs_dirs if they do not exist Feb 5, 2025
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Feb 5, 2025
@holzman
Copy link
Author

holzman commented Feb 5, 2025

Ah, my bad. I'll revise the failing tests and update this PR.

@holzman
Copy link
Author

holzman commented Feb 5, 2025

Actually, I think this exposed an issue with #3692:

In 2.0.5, -r took precedence over MAMBA_ROOT_PREFIX:

$ export MAMBA_ROOT_PREFIX=/tmp/envroot
$ mamba create  --debug -n foo --print-config-only | yq '. | .envs_dirs'
[
  "/tmp/envroot/envs"
]

$ mamba create -r /tmp/cliroot --debug -n foo --print-config-only | yq '. | .envs_dirs'
[
  "/tmp/cliroot/envs"
]

but in 2.0.6:

$ mamba create -r /tmp/cliroot --debug -n foo --print-config-only | yq '. | .envs_dirs'
[
  "/tmp/envroot/envs",
  "/tmp/cliroot/envs"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mamba create does not create env_dirs (and parents) if they do not exist
2 participants