fix: Add x86_64 archspec support for Windows
#3803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
commented
Feb 5, 2025
| int cpu_info[4]; | ||
| int eax_value = 7; | ||
| int ecx_value = 0; | ||
| __cpuidex(cpu_info, eax_value, ecx_value); |
There was a problem hiding this comment.
Note to reviewers: I am wondering whether more checks are needed to check that 7 and 0 are valid value for eax_value and ecx_value (AKA leaf and subleaf in Intel's terminology).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3795.