Skip to content

Commit

Permalink
chore: some function argument name different.
Browse files Browse the repository at this point in the history
1. Variable 'child' can be declared as pointer to const.
2. Function 'moveItem' argument 3 names different: declaration 'row' definition 'newRow'.
3. Function 'swapItems' argument 2 names different: declaration 'startRow' definition 'firstRow'.
4. Function 'insertChild' argument 2 names different: declaration 'index' definition 'i'.
  • Loading branch information
GongHeng2017 committed Jan 13, 2025
1 parent 88aa7b8 commit c950f9a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions qt/src/hocr/HOCRDocument.cc
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ QModelIndex HOCRDocument::indexAtItem(const HOCRItem* item) const {
parent = parent->parent();
}
QModelIndex idx;
for(HOCRItem* parent : parents) {
for(const HOCRItem* parent : parents) {
idx = index(parent->index(), 0, idx);
}
return index(item->index(), 0, idx);
Expand Down Expand Up @@ -942,15 +942,15 @@ void HOCRItem::getPropagatableAttributes(QMap<QString, QMap<QString, QSet<QStrin
QString childClass = m_childItems.isEmpty() ? "" : m_childItems.front()->itemClass();
auto it = s_propagatableAttributes.find(childClass);
if(it != s_propagatableAttributes.end()) {
for(HOCRItem* child : m_childItems) {
for(const HOCRItem* child : m_childItems) {
QMap<QString, QString> attrs = child->getAttributes(it.value());
for(auto attrIt = attrs.begin(), attrItEnd = attrs.end(); attrIt != attrItEnd; ++attrIt) {
occurrences[childClass][attrIt.key()].insert(attrIt.value());
}
}
}
if(childClass != "ocrx_word") {
for(HOCRItem* child : m_childItems) {
for(const HOCRItem* child : m_childItems) {
child->getPropagatableAttributes(occurrences);
}
}
Expand Down
6 changes: 3 additions & 3 deletions qt/src/hocr/HOCRDocument.hh
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ public:
}
QModelIndex indexAtItem(const HOCRItem* item) const;
bool editItemAttribute(const QModelIndex& index, const QString& name, const QString& value, const QString& attrItemClass = QString());
QModelIndex moveItem(const QModelIndex& itemIndex, const QModelIndex& newParent, int row);
QModelIndex swapItems(const QModelIndex& parent, int startRow, int endRow);
QModelIndex moveItem(const QModelIndex& itemIndex, const QModelIndex& newParent, int newRow);
QModelIndex swapItems(const QModelIndex& parent, int firstRow, int secondRow);
QModelIndex mergeItems(const QModelIndex& parent, int startRow, int endRow);
QModelIndex splitItem(const QModelIndex& itemIndex, int startRow, int endRow);
QModelIndex splitItemText(const QModelIndex& itemIndex, int pos);
Expand Down Expand Up @@ -208,7 +208,7 @@ protected:

// All mutations must be done through methods of HOCRDocument
void addChild(HOCRItem* child);
void insertChild(HOCRItem* child, int index);
void insertChild(HOCRItem* child, int i);
void removeChild(HOCRItem* child);
void takeChild(HOCRItem* child);
QVector<HOCRItem*> takeChildren();
Expand Down

0 comments on commit c950f9a

Please sign in to comment.