Skip to content

Commit

Permalink
Fix build failure on CI
Browse files Browse the repository at this point in the history
- Adds annotation `@Deprecated` to Tag1 file that was deprecated via javadoc tag.
- Adds org.junit.platform:junit-platform-launcher that was causing tests to fail on CI.
- Build and run tests in a single pass again (after spotting the CI build issues).

Signed-off-by: Manoel Campos <[email protected]>
  • Loading branch information
manoelcampos committed Jan 31, 2025
1 parent e349cd6 commit a729754
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,4 @@ jobs:
java-version: '21'
distribution: 'temurin'
- name: Build with Gradle
run: ./gradlew build -x test check --warning-mode none
- name: Run tests
run: ./gradlew test
run: ./gradlew build check --warning-mode none
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ dependencies {
testImplementation 'org.slf4j:slf4j-simple:+'
testImplementation 'org.junit.jupiter:junit-jupiter-api:+'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:+'
testRuntimeOnly 'org.junit.platform:junit-platform-launcher:+'

// https://mvnrepository.com/artifact/net.sf.saxon/Saxon-HE
implementation 'net.sf.saxon:Saxon-HE:+'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

/**
* Tag1
*
*
* @author author
* @deprecated deprecated
* @category category
Expand All @@ -11,10 +11,11 @@
* @since since
* @version version
*/
@Deprecated
public class Tag1 {
/**
* The famous <code>foo</code> method.
*
*
* @param bar bar
* @return object
* @throws NullPointerException exception
Expand Down

0 comments on commit a729754

Please sign in to comment.