JDK 21 (WIP) - Close #3 #4
Conversation
Signed-off-by: Manoel Campos <[email protected]>
…vy/CustomVersionTask.groovy. Removes the function implementation from build.gradle Signed-off-by: Manoel Campos <[email protected]>
Signed-off-by: Manoel Campos <[email protected]>
Properties such as fromRepo are now a Property object that has a set method, which must be called instead of assigning a value to the property directly. Previously properties such as fromRepo were String, now they are Property<String>, requiring the set() call. Signed-off-by: Manoel Campos <[email protected]>
|
Now instantiation erros are being catch and logged. |
Signed-off-by: Manoel Campos <[email protected]>
|
jdeps -summary build/libs/xml-doclet-all.jar may help configuring modules |
Signed-off-by: Manoel Campos <[email protected]>
…on name, that was causing the doclet instantiation to fail, indicating invalid option name. Signed-off-by: Manoel Campos <[email protected]>
|
Doclet is now being instantiated, but we still have this module hell. |
|
Greetings! So the initiation error was on parameters/option only?
We can remove module-info.java, its not really needed. |
Signed-off-by: Manoel Campos <[email protected]>
|
Now it starts without instantiation errors, but we get lots of runtime errors such as: build/generated/sources/java/main/com/github/markusbernhardt/xmldoclet/xjc/EnumConstant.java:14: error: package jakarta.xml.bind.annotation does not exist Since I'm using the uber jar, the dependencies are expected to be inside it. |
Just commit everything straight into the Repo (origin:master). We don't need PRs at that point since this is a very volatile development stage. |
|
I am pulling this in already so I can continue working on it. |
Close #3
Changes so far
Fix gradle build and some deprecations.
To generate the fat jar you have to run
./gradlew shadowJarIt will create a xml-doclet-all.jar inside build/libs.
The doclet is not running yet.
You can start it by typing:
@manticore-projects, I don't know if you are making some changes too, because that may cause merge conflicts.
Finally, since this is an independent fork, what do you think of detaching it from the original project?
This way, the following options on the repo home page will desapear and it will be easier to open PRs from feature branches (currently, a new PR targets the original repo).
To detach the project, you just need to access https://support.github.com/tickets/personal/0 and click "New Ticket". Then, send a message to the support, informing that now you have an independent fork that you want to detach from the original project.
I'll try to figure out why the doclet is not running. The major challenge is that there is no logs, just a generic error message "error: Could not instantiate class com.github.markusbernhardt.xmldoclet.XmlDoclet"