Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to new ARKit (Fixes compilation issues for non IOS devices) #1462

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

devedse
Copy link

@devedse devedse commented Sep 14, 2019

Related issue

Fixes #1459

Description of changes

  • Updated ARKit to the latest version
  • Updated to the latest 2017 unity version

QA checklists

  • [N/A] Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • [N/A] Add tests for new/changed/updated classes and methods!!!
  • [N/A] Check out conventions in CONTRIBUTING.md.
  • [N/A] Check out conventions in CODING-STYLE.md
  • [TODO] Update the changelog
  • [TODO] Update documentation.

Reviewers

Todo

There's some items that have to be done before this should be merged:

  1. Review (Main question I have is, if this should be completely compiler excluded for non IOS devices):
    https://github.com/devedse/mapbox-unity-sdk/blob/develop/sdkproject/Assets/UnityARInterface/Scripts/ARKitInterface.cs
  2. Check if there's any need for additional documentation / dependencies

@devedse devedse mentioned this pull request Sep 14, 2019
@devedse
Copy link
Author

devedse commented Oct 16, 2019

@Guardiola31337 , trying to get some attention to this PR 😄. Is this something that could be merged?

Copy link

@cheesemichael cheesemichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works. Would also like to confirm that ARKitInterface.cs can be completely excluded from the compiling

Copy link

@AbrarAmin1 AbrarAmin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me. But ar camera is black

@iliasmour
Copy link

Is there any solution after all? Can we build on android platform? Please I try 2 weeks to find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android 64bit Error
4 participants