Use qt_add_plugin #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other things that are probably more appropriate for Qt plugins, this changes the plugin's extension on macOS from .so to .dylib, which will hopefully cause it to be automatically shipped by macdeployqt. Based on @Nerixyz's work in jurplel/QtApng#4. Changed target name from qaseprite to AsepriteImagePlugin to match the class name, since the CLASS_NAME parameter wasn't working correctly with qt5_add_plugin. Closes mapeditor#8
* Removed faulty 'arg_MODULE' check for changing suffix to .dylib * Updated artifact names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the plugin's extension on macOS from
.soto.dylib, which will hopefully cause it to be automatically shipped by macdeployqt.Closes #8