-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render locale specific time stamp #291
base: main
Are you sure you want to change the base?
Conversation
compact ? | ||
[date[3]] : | ||
[date[1], date[2] + ",", date[3]] : | ||
date).join(" "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, the current implementation looks a bit overly complex to me or has dead code. Since this will always be true:
new Date(capturedAt).toDateString().split(" ").length > 3
Unless, Date.toDateString()
is JavaScript runtime implementation specific, and thus behaves differently on different browsers. But, I am not aware of that.
The time stamp formatting across all Mapillary products, even within products, is quite inconsistent. It should be best to finally make it uniform. Besides, this is very easy to fix. 😉 |
Hi @gitne! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
I do not want to sound rude but I am still displeased with the current situation with regards to time stamps in Mapillary products and how Mapillary has approached i18n and/or l11n in general, especially since the Facebook takeover. 😞 The internet has always been a place where many cultures and languages meet and communicate, even Mapillary’s parent company has understood this for a long time. If you do not want to support multiple cultures and languages (which is completely acceptable and understandable) then please at least adhere to and be consistent in ISO standards. So, I would be very happy if this PR could find its way into Mapillary products in one way or the other. Thank you! |
Currently, the default
en-US
rendering is often very confusing to users in other locales. This PR renders the time stamp in a locale specific manner.