Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mara_db click group #74

Merged
merged 3 commits into from
Nov 21, 2023
Merged

add mara_db click group #74

merged 3 commits into from
Nov 21, 2023

Conversation

leo-schick
Copy link
Member

This adds the commands via a click group. In the future, cli commands should be run via

flask mara-db migrate

instead of

flask mara_db.migrate

Using the old syntax produces a warning that the old style will be dropped in version 5.0.

In the future, a new package with an entrypoint mara will trim leading mara- from the click group name. Then it would be possible to run e.g.

mara db migrate

But to avoid complications with other packages (see discussion in mara/mara-app#44), we use the module name as click group name.

@leo-schick leo-schick requested a review from jankatins March 1, 2023 23:12
@leo-schick leo-schick merged commit 3ea3111 into main Nov 21, 2023
5 checks passed
@leo-schick leo-schick deleted the add-group-cli branch November 22, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant