Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: winit v0.30.0 + glutin-winit v0.5.0 + accesskit v0.14.0 + accesskit_winit v0.20.0 #598

Merged
merged 15 commits into from
Jun 10, 2024

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented Apr 30, 2024

@marc2332 marc2332 added the internal impovement👍 Internal code improvements label Apr 30, 2024
@marc2332 marc2332 added dependencies Pull requests that update a dependency file enhancement 🔥 New feature or request labels May 1, 2024
@marc2332 marc2332 changed the title feat: Bump accesskit, winit and glutin feat: winit v0.30.0 + glutin-winit v0.5.0 + accesskit_winit v0.20.0 May 1, 2024
@marc2332 marc2332 changed the title feat: winit v0.30.0 + glutin-winit v0.5.0 + accesskit_winit v0.20.0 feat: winit v0.30.0 + glutin-winit v0.5.0 + accesskit v0.14.0 + accesskit_winit v0.20.0 May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 0.26882% with 742 lines in your changes missing coverage. Please review.

Project coverage is 74.26%. Comparing base (6be74f9) to head (d357920).

Current head d357920 differs from pull request most recent head e09a160

Please upload reports for the commit e09a160 to get more accurate results.

Files Patch % Lines
crates/renderer/src/renderer.rs 0.00% 528 Missing ⚠️
crates/renderer/src/render.rs 0.00% 103 Missing ⚠️
crates/renderer/src/app.rs 0.00% 50 Missing ⚠️
crates/renderer/src/config.rs 0.00% 36 Missing ⚠️
crates/renderer/src/accessibility.rs 0.00% 13 Missing ⚠️
crates/freya/src/launch.rs 0.00% 7 Missing ⚠️
crates/common/src/event_messages.rs 0.00% 2 Missing ⚠️
examples/installer/src/main.rs 0.00% 2 Missing ⚠️
...es/core/src/accessibility/accessibility_manager.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   74.32%   74.26%   -0.07%     
==========================================
  Files         196      194       -2     
  Lines       20251    20267      +16     
==========================================
- Hits        15052    15051       -1     
- Misses       5199     5216      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be interesting to try enabling vsync

@marc2332 marc2332 marked this pull request as ready for review May 28, 2024 22:17
@marc2332 marc2332 marked this pull request as draft May 28, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement 🔥 New feature or request internal impovement👍 Internal code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant