Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double buffering for data printing #17

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

mscuttari
Copy link
Member

No description provided.

@mscuttari mscuttari requested a review from a team as a code owner October 28, 2024 21:49
@mscuttari mscuttari linked an issue Oct 28, 2024 that may be closed by this pull request
@mscuttari mscuttari requested a review from thaugdahl October 28, 2024 21:50
@mscuttari
Copy link
Member Author

mscuttari commented Oct 28, 2024

@thaugdahl I've added a first draft for double buffering the output values. For now the buffer is filled sequentially, but the infrastructure is designed to easily switch to a multithreaded solution. It would be nice if you can try it out and see how the performance is.

@thaugdahl
Copy link
Contributor

Performance impact is negligible. This approach should enable some nicer buffered and/or parallel I/O in the future. LGTM.

thaugdahl
thaugdahl previously approved these changes Nov 1, 2024
Copy link
Contributor

@thaugdahl thaugdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscuttari
Copy link
Member Author

/fast-forward

@github-actions github-actions bot merged commit 703fa24 into master Nov 2, 2024
4 checks passed
@github-actions github-actions bot deleted the output-buffering branch November 2, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output buffering
3 participants