Skip to content

Commit

Permalink
Build webkit2gtk4.0/4.1 versions for Linux + fix codesigning for Wind…
Browse files Browse the repository at this point in the history
…ows portable

Signed-off-by: Marcus Crane <[email protected]>
  • Loading branch information
marcus-crane committed Dec 7, 2024
1 parent dab0359 commit 317db67
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 6 deletions.
26 changes: 21 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ jobs:
- platform: darwin/universal
os: macos-latest
tag: darwin_universal
- arch: amd64
platform: linux/amd64
os: ubuntu-latest
tag: linux_amd64_webkit2gtk40
- arch: amd64
platform: linux/amd64
os: ubuntu-latest
Expand Down Expand Up @@ -111,12 +115,24 @@ jobs:
# Build -- app variants

## Linux
- name: Build wails app for Linux / macOS
if: runner.os == 'Linux' || runner.os == 'macOS'
## Linux (webkit2gtk-4.0) -- We explicitly set 4.0 in this tag because it'll only be less used over time
- name: Build wails app for Linux (webkit2gtk-4.0)
if: runner.os == 'Linux' && matrix.build.tag == 'linux_amd64_webkit2gtk40'
shell: bash
run: wails build -platform ${{ matrix.build.platform }} -ldflags "-X main.version=v${{ steps.normalise_version.outputs.version }}"


## Linux (webkit2gtk-4.1) -- We set this as the new default as more users will use 24.0x+ over time
- name: Build wails app for Linux (webkit2gtk-4.1)
if: runner.os == 'Linux' && matrix.build.tag == 'linux_amd64'
shell: bash
run: wails build -platform ${{ matrix.build.platform }} -ldflags "-X main.version=v${{ steps.normalise_version.outputs.version }}"

## macOS
- name: Build wails app for macOS
if: runner.os == 'macOS'
shell: bash
run: wails build -platform ${{ matrix.build.platform }} -ldflags "-X main.version=v${{ steps.normalise_version.outputs.version }}"

## Windows
- name: Build Windows NSIS installer (Normal)
if: runner.os == 'Windows' && matrix.build.tag == 'windows_amd64'
Expand Down Expand Up @@ -153,7 +169,7 @@ jobs:
working-directory: ./build/bin

- name: Codesign Windows Portable
if: runner.os == 'Windows' && matrix.build.portable == 'windows-portable_amd64' && startsWith(github.ref, 'refs/tags/')
if: runner.os == 'Windows' && matrix.build.tag == 'windows-portable_amd64' && startsWith(github.ref, 'refs/tags/')
run: |
echo "Creating certificate file"
New-Item -ItemType directory -Path certificate
Expand Down
2 changes: 1 addition & 1 deletion build/linux/october_0.0.0_ARCH/DEBIAN/control
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Version: 0.0.0
Section: base
Priority: optional
Architecture: ARCH
Depends: libgtk-3-dev, libwebkit2gtk-4.0-dev
Depends: libgtk-3-dev, libwebkit2gtk-4.0-dev | libwebkit2gtk-4.1-dev
Maintainer: Marcus Crane <[email protected]>
Homepage: https://october.utf9k.net
Description: A tool for syncing your Kobo highlights with Readwise

0 comments on commit 317db67

Please sign in to comment.