Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrolling issue #1

Merged
merged 8 commits into from
Nov 16, 2023
Merged

fix: scrolling issue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c7f0198
fix(#299): fix scrolling issue (#314)
wridgeu Nov 16, 2023
e0762ab
chore: bump ui5, tooling and wdi5 versions (#315)
wridgeu Nov 16, 2023
a8d2569
chore: update node
marianfoo Nov 16, 2023
79d554e
chore: update node
marianfoo Nov 16, 2023
3f7f416
chore: update node
marianfoo Nov 16, 2023
82a5bcc
chore: update node
marianfoo Nov 16, 2023
d4f7df4
chore: update node
marianfoo Nov 16, 2023
87482c0
chore: update node
marianfoo Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/azure_static_create.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
with:
submodules: true
- name: use node 16
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- name: install
run: npm install
- name: build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/azure_static_update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ jobs:
with:
submodules: true
- name: use node 16
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- name: npm install
run: npm install
- name: Build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
- name: Checkout code
uses: actions/checkout@v3
- name: Use Node.js LTS (16.x)
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: "16"
node-version: "18"
- name: npm install
run: |
npm install
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/create_demo_apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
with:
repository: SAP/openui5-sample-app
- name: use node 16
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- name: install
run: npm install
- name: build
Expand All @@ -39,9 +39,9 @@ jobs:
with:
repository: SAP-samples/ui5-typescript-helloworld
- name: use node 16
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- name: install
run: npm install
- name: build
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/wdi5-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,10 @@ jobs:
- name: check out repo
uses: actions/checkout@v3

- name: use node 16
uses: actions/setup-node@v2
- name: use node 18
uses: actions/setup-node@v4
with:
node-version: 16
cache: "npm"
cache-dependency-path: "**/package-lock.json"
node-version: 18

# we need this for workspace mgmt
- name: check npm version >= 7
Expand Down Expand Up @@ -51,10 +49,10 @@ jobs:
- name: check out repo
uses: actions/checkout@v3

- name: use node 16
uses: actions/setup-node@v2
- name: use node 18
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
cache: "npm"
cache-dependency-path: "**/package-lock.json"

Expand Down
Loading
Loading