Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set build_flags: [-v, -i] if empty for compatibility, small updates to doc #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flibustenet
Copy link
Contributor

I didn't know how to differentiate between empty build_flags:[] and not set at all.
I updated the refresh.yml of the readme with the current init.

@opalfroot
Copy link
Contributor

opalfroot commented Jul 2, 2017

I think the difficulty with this is that you're trying to proxy configuration options through YML then applying defaults which feels like we're overriding configurable behaviour.

The build flags could be set via composition within the main config and have a validation function to determine if the user specific config is runnable. This would be quick and easy and a better alternative to overriding user configuration.

Alternatively a validation function on the main config might be just as simple

@flibustenet
Copy link
Contributor Author

I'm not sure to see what you mean, i prefer to let you do it if you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants