-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fix bootstrap script and general improvements #45
Conversation
- proper bootstrap script - rename setup.sh to run.sh and clean up - remove need for sudo in local.sh - move computer rename to macos.sh - create dotsync.sh - general cleanup
Reviewer's Guide by SourceryThis PR reorganizes and improves the dotfiles setup scripts by introducing proper bootstrapping, better script organization, and automated installation capabilities. The changes focus on making the installation process more streamlined, adding 1Password integration for secrets management, and improving the overall user experience with better feedback and idempotent operations. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment in run.sh explaining why macos.sh is disabled and what needs to be fixed before re-enabling it
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
…bao/dotfiles into chore/bugfixes-and-improvements
Summary by Sourcery
Revamp the bootstrap process by introducing a new 'dotsync.sh' script for dotfile management, renaming 'setup.sh' to 'run.sh', and removing 'sudo' requirements from 'local.sh'. Update the README and LICENSE to reflect these changes and improve script idempotency and security by integrating 1Password for secret management.
New Features:
Enhancements:
Documentation: