Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug in dock.sh #53

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Fix bug in dock.sh #53

merged 1 commit into from
Nov 8, 2024

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Nov 8, 2024

  • fix bug introduced by lint fix

Summary by Sourcery

Fix a bug in dock.sh related to argument handling and enhance the readability of run.sh by reorganizing its structure and adding section headers.

Bug Fixes:

  • Fix a bug in dock.sh by correctly shifting arguments in the add_folder_to_dock function.

Enhancements:

  • Reorganize the script flow in run.sh to improve readability and maintainability by adding section headers and moving the local.sh execution to a more appropriate location.

- fix bug introduced by lint fix
Copy link

trunk-io bot commented Nov 8, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR fixes a bug in the dock.sh script and includes several script improvements. The main changes involve fixing argument handling in the add_folder_to_dock function, reorganizing sections in run.sh, improving CI detection, and updating some visual elements.

Sequence diagram for add_folder_to_dock function argument handling

sequenceDiagram
    participant User
    participant Script as dock.sh
    User->>Script: Call add_folder_to_dock with arguments
    Script->>Script: Set folder_path from first argument
    Script->>Script: shift to remove folder_path from args
    Script->>Script: Process remaining arguments
    Script->>Script: shift to next argument
    Script->>User: Complete function execution
Loading

File-Level Changes

Change Details Files
Fix argument handling in add_folder_to_dock function
  • Add shift command to remove folder_path from args after processing
  • Add additional shift to properly handle argument pairs
dock.sh
Reorganize script sections and improve readability
  • Add section headers for Linux and CI exits
  • Move local.sh execution after dock.sh
  • Remove redundant comment about OS support
run.sh
Improve CI detection and handling
  • Change GITHUB_ACTIONS check to more generic CI variable
  • Add default value handling for CI variable
  • Use parameter expansion with default value for CI detection
run.sh
linkme/.zprofile
Update visual elements in bootstrap script
  • Change clone operation emoji from chain to document
bootstrap.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

dock.sh Show resolved Hide resolved
@martimlobao martimlobao merged commit 05435b4 into main Nov 8, 2024
8 checks passed
@martimlobao martimlobao deleted the fix/dock-script branch November 8, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant