Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure aws-sso cli #65

Merged
merged 1 commit into from
Nov 16, 2024
Merged

feat: Configure aws-sso cli #65

merged 1 commit into from
Nov 16, 2024

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Nov 16, 2024

  • load sensitive aws account IDs from 1Password

Summary by Sourcery

New Features:

  • Introduce a new AWS SSO configuration file to manage AWS account access.

- load sensitive aws account IDs from 1Password
Copy link

trunk-io bot commented Nov 16, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Nov 16, 2024

Reviewer's Guide by Sourcery

This PR adds AWS SSO CLI configuration by introducing a new YAML configuration file that sets up AWS SSO authentication parameters, console settings, and UI customization for better user experience.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Configure AWS SSO CLI with Revelio SSO settings
  • Set up SSO configuration with Revelio as the default provider
  • Configure SSO region and start URL for authentication
  • Set default region to us-east-2
  • Configure console duration and cache refresh settings
/linkme/.aws-sso/config.yaml
Customize AWS SSO CLI user interface
  • Define profile format for display
  • Configure account primary tags for identification
  • Set up prompt colors for better visual distinction
  • Specify list fields for account information display
/linkme/.aws-sso/config.yaml
Configure operational parameters
  • Set up threading and retry parameters
  • Configure history tracking settings
  • Enable full text search functionality
  • Set error-level logging
/linkme/.aws-sso/config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add a brief documentation comment explaining the purpose of this AWS SSO configuration and any company-specific settings.
  • Consider expanding the PR description to explain what problem this configuration solves and its impact.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit 73c0a69 into main Nov 16, 2024
8 checks passed
@martimlobao martimlobao deleted the feat/aws-sso-cli branch November 16, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant