Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up and zap #66

Merged
merged 1 commit into from
Nov 16, 2024
Merged

chore: Clean up and zap #66

merged 1 commit into from
Nov 16, 2024

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Nov 16, 2024

  • use brew uninstall --zap when removing apps and formula
  • remove unused oh-my-zsh theme

Summary by Sourcery

Clean up the configuration by removing an unused oh-my-zsh theme and enhance the uninstall process by using 'brew uninstall --zap' for a more comprehensive removal of apps and formulae.

Enhancements:

  • Use 'brew uninstall --zap' for removing apps and formulae to ensure a more thorough cleanup.

Chores:

  • Remove unused oh-my-zsh theme from configuration.

- use `brew uninstall --zap` when removing apps and formula
- remove unused oh-my-zsh theme
Copy link

trunk-io bot commented Nov 16, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Nov 16, 2024

Reviewer's Guide by Sourcery

This PR makes two main changes: it removes unused oh-my-zsh theme configuration from .zshrc and modifies the brew uninstall command to use the --zap flag for more thorough removal of applications.

Sequence diagram for brew uninstall process with --zap

sequenceDiagram
    participant User
    participant Script
    participant Brew

    User->>Script: Run brew_sync function
    Script->>Brew: brew uninstall --zap <app>
    Brew-->>Script: App uninstalled with zap
    Script-->>User: Confirmation of uninstallation
Loading

File-Level Changes

Change Details Files
Remove unused oh-my-zsh theme configuration
  • Remove ZSH_THEME setting for robbyrussell theme
  • Remove commented configuration for random theme selection
linkme/.zshrc
Enhance brew uninstall command with --zap flag
  • Add --zap flag to brew uninstall command for more thorough application removal
install.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit bc5ac07 into main Nov 16, 2024
8 checks passed
@martimlobao martimlobao deleted the chore/cleanup-and-zap branch November 16, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant