Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ruff and trunk settings #68

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore: Ruff and trunk settings #68

merged 1 commit into from
Nov 25, 2024

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Nov 25, 2024

  • add ruff to shell completion
  • remove deprecated ruff rules
  • remove trunk pre-commit hook for push

Summary by Sourcery

Update shell completion to include Ruff, clean up deprecated Ruff rules, and remove the trunk pre-commit hook for push.

Enhancements:

  • Remove deprecated Ruff rules from the configuration file.

CI:

  • Remove the trunk pre-commit hook for push from the trunk configuration.

Chores:

  • Add Ruff to shell completion in the zsh configuration.

- add ruff to shell completion
- remove deprecated ruff rules
- remove trunk pre-commit hook for push
Copy link

trunk-io bot commented Nov 25, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR makes configuration updates to shell completion and linting tools. It adds Ruff shell completion support, removes deprecated Ruff rules from the configuration, and simplifies the Trunk CI setup by removing the pre-push hook.

Sequence diagram for shell completion update

sequenceDiagram
    participant User
    participant Zsh
    participant Ruff
    User->>Zsh: Open terminal
    Zsh->>Ruff: Execute ruff generate-shell-completion zsh
    Ruff-->>Zsh: Provide shell completion
    Zsh-->>User: Display shell completion for Ruff
Loading

Class diagram for Ruff configuration update

classDiagram
    class RuffConfig {
        +preview: bool
        +select: list
        +fixable: list
        +ignore: list
    }
    note for RuffConfig "Removed deprecated rules ANN101 and ANN102 from ignore list"
Loading

File-Level Changes

Change Details Files
Added shell completion support for Ruff
  • Added Ruff shell completion generation command
linkme/.zshrc
Updated Ruff linting configuration
  • Removed deprecated rules ANN101 (missing-type-self) and ANN102 (missing-type-cls)
linkme/.config/ruff/ruff.toml
Simplified Trunk CI configuration
  • Removed trunk-check-pre-push from enabled actions
.trunk/trunk.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit 57b0214 into main Nov 25, 2024
8 checks passed
@martimlobao martimlobao deleted the chore/ruff-and-lint branch November 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant