-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ghostty #85
feat: Ghostty #85
Conversation
- add Ghostty - configure Ghostty to mimick Hyper appearance
Merging to
|
Reviewer's Guide by SourceryThis pull request adds Ghostty as a terminal emulator and configures it to mimic the appearance of Hyper. State diagram for terminal title behaviorstateDiagram-v2
[*] --> CheckPath
CheckPath --> HomeDirectory: PWD == HOME
CheckPath --> OtherDirectory: PWD != HOME
HomeDirectory --> SetTitle: Display '~'
OtherDirectory --> SetTitle: Display basename
SetTitle --> [*]
Flow diagram for terminal emulator replacementflowchart LR
subgraph Before
Hyper[Hyper Terminal]
end
subgraph After
Ghostty[Ghostty Terminal]
end
Before -->|Replaced by| After
style Hyper fill:#f96,stroke:#333
style Ghostty fill:#9f6,stroke:#333
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Consider using printf instead of eval for setting the terminal title to avoid potential command injection vulnerabilities. (link)
Overall Comments:
- The Ghostty config file is empty but the PR description mentions configuring it to match Hyper's appearance. Please add the necessary configuration to achieve this.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🔴 Security: 1 blocking issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Summary by Sourcery
Replace Hyper with Ghostty as the default terminal emulator.
Enhancements:
Chores: