Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ghostty #85

Merged
merged 3 commits into from
Jan 23, 2025
Merged

feat: Ghostty #85

merged 3 commits into from
Jan 23, 2025

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Jan 23, 2025

  • add Ghostty
  • configure Ghostty to mimick Hyper appearance

Summary by Sourcery

Replace Hyper with Ghostty as the default terminal emulator.

Enhancements:

  • Disable automatic terminal title setting and add a custom pre-command to display the current folder in the terminal title.

Chores:

  • Update the copyright year in LICENSE.md.

- add Ghostty
- configure Ghostty to mimick Hyper appearance
Copy link

trunk-io bot commented Jan 23, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Jan 23, 2025

Reviewer's Guide by Sourcery

This pull request adds Ghostty as a terminal emulator and configures it to mimic the appearance of Hyper.

State diagram for terminal title behavior

stateDiagram-v2
    [*] --> CheckPath
    CheckPath --> HomeDirectory: PWD == HOME
    CheckPath --> OtherDirectory: PWD != HOME
    HomeDirectory --> SetTitle: Display '~'
    OtherDirectory --> SetTitle: Display basename
    SetTitle --> [*]
Loading

Flow diagram for terminal emulator replacement

flowchart LR
    subgraph Before
      Hyper[Hyper Terminal]
    end
    subgraph After
      Ghostty[Ghostty Terminal]
    end
    Before -->|Replaced by| After
    style Hyper fill:#f96,stroke:#333
    style Ghostty fill:#9f6,stroke:#333
Loading

File-Level Changes

Change Details Files
Added Ghostty terminal emulator.
  • Added Ghostty to the list of applications managed by brew.
  • Added Ghostty to the dock.
apps.toml
dock.sh
linkme/.config/ghostty/config
Configured Ghostty to mimic Hyper's appearance.
  • Disabled auto-setting of the terminal title.
  • Set terminal title to current folder.
linkme/.zshrc
Updated the copyright year.
  • Removed the year range and kept the current year.
LICENSE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Consider using printf instead of eval for setting the terminal title to avoid potential command injection vulnerabilities. (link)

Overall Comments:

  • The Ghostty config file is empty but the PR description mentions configuring it to match Hyper's appearance. Please add the necessary configuration to achieve this.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🔴 Security: 1 blocking issue
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

linkme/.zshrc Outdated Show resolved Hide resolved
LICENSE.md Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@martimlobao martimlobao merged commit 347b3bc into main Jan 23, 2025
7 checks passed
@martimlobao martimlobao deleted the feat/ghostty branch January 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant