Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Tunnelblick with OpenVPN Connect #89

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Jan 28, 2025

  • tunnelblick was constantly freezing up
  • also add pylint

Summary by Sourcery

New Features:

  • Add OpenVPN Connect.

- tunnelblick was constantly freezing up
- also add pylint
Copy link

trunk-io bot commented Jan 28, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Jan 28, 2025

Reviewer's Guide by Sourcery

This pull request replaces Tunnelblick with OpenVPN Connect and adds pylint to the list of installed tools. The change was made due to Tunnelblick constantly freezing.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Replaced Tunnelblick with OpenVPN Connect.
  • Removed the 'tunnelblick' cask.
  • Added the 'openvpn-connect' cask.
apps.toml
Added pylint to the list of installed tools.
  • Added 'pylint' to the 'uv' section.
apps.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The commit message could be more descriptive. Please explain the specific issues encountered with Tunnelblick and why OpenVPN Connect is a better choice.
  • Consider if both pylint and ruff are necessary, as they may have overlapping functionality and potentially conflicting rules. Ruff is generally faster and can handle most Python linting needs.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit 8b10d0c into main Jan 28, 2025
8 checks passed
@martimlobao martimlobao deleted the feat/openvpn branch January 28, 2025 21:00
@martimlobao martimlobao mentioned this pull request Jan 29, 2025
martimlobao added a commit that referenced this pull request Jan 29, 2025
- set default `.pylintrc`
- related to #89

## Summary by Sourcery

Chores:
- Introduce a default pylintrc file to standardize code style and
quality checks across the project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant