-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace Tunnelblick with OpenVPN Connect #89
Conversation
- tunnelblick was constantly freezing up - also add pylint
Merging to
|
Reviewer's Guide by SourceryThis pull request replaces Tunnelblick with OpenVPN Connect and adds pylint to the list of installed tools. The change was made due to Tunnelblick constantly freezing. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes - here's some feedback:
Overall Comments:
- The commit message could be more descriptive. Please explain the specific issues encountered with Tunnelblick and why OpenVPN Connect is a better choice.
- Consider if both pylint and ruff are necessary, as they may have overlapping functionality and potentially conflicting rules. Ruff is generally faster and can handle most Python linting needs.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- set default `.pylintrc` - related to #89 ## Summary by Sourcery Chores: - Introduce a default pylintrc file to standardize code style and quality checks across the project.
Summary by Sourcery
New Features: