-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Reorganize and clean #92
Conversation
- move computer name function from macos.sh to local.sh since it uses 1Password - print serial and model - tweak print messages
Merging to
|
Reviewer's Guide by SourceryThis pull request reorganizes the scripts, moving the computer name function to local.sh, and adds printing of serial and model information. It also tweaks some print messages for clarity. Sequence diagram for computer name setting processsequenceDiagram
participant User
participant Script
participant System
participant 1Password
Script->>System: Get hardware UUID, serial, model
Script->>1Password: Look up computer name
alt Name not found
Script->>User: Prompt for computer name
User->>Script: Provide name
Script->>1Password: Save name, serial, model
end
Script->>System: Get current computer name
alt Name different from current
Script->>System: Set computer name
Script->>System: Set NetBIOS name
Script->>System: Set LocalHostName
Script->>System: Set HostName
end
Flow diagram for script organization changesflowchart TB
subgraph Before
macos[macos.sh]
macos -->|contains| computer[Computer Name Function]
end
subgraph After
local[local.sh]
local -->|contains| computer2[Computer Name Function]
local -->|uses| op[1Password]
end
Before -->|moved to| After
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Summary by Sourcery
Move the computer name function from macos.sh to local.sh, print the serial and model of the computer, and update print messages.
New Features:
Enhancements:
Chores: