refactor: Simplify profile image selection logic

mash-up-kr · Aug 19, 2024 · 1523a2e · 1523a2e
1 parent 0c07be4
commit 1523a2e
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/service/src/main/kotlin/com/mashup/dojo/service/DefaultPickService.kt b/service/src/main/kotlin/com/mashup/dojo/service/DefaultPickService.kt
@@ -352,14 +352,11 @@ class DefaultPickService(
         pickerGender: MemberGender?,
         pickerFullName: String?,
     ): String {
-        return if (pickerFullName != null) {
-            pickerProfileImageUrl
-        } else {
-            when (pickerGender) {
-                MemberGender.MALE -> profileImageProperties.male
-                MemberGender.FEMALE -> profileImageProperties.female
-                else -> profileImageProperties.unknown
-            }
+        return when {
+            pickerFullName != null -> pickerProfileImageUrl
+            pickerGender == MemberGender.MALE -> profileImageProperties.male
+            pickerGender == MemberGender.FEMALE -> profileImageProperties.female
+            else -> profileImageProperties.unknown
         }
     }