refactor : imageUrl property to emojiImageId

mash-up-kr · Jun 29, 2024 · 49d1a46 · 49d1a46
1 parent 58b663e
commit 49d1a46
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/api/src/main/kotlin/com/mashup/dojo/QuestionController.kt b/api/src/main/kotlin/com/mashup/dojo/QuestionController.kt
@@ -1,6 +1,7 @@
 package com.mashup.dojo
 
 import com.mashup.dojo.common.DojoApiResponse
+import com.mashup.dojo.domain.QuestionId
 import com.mashup.dojo.dto.QuestionCreateRequest
 import com.mashup.dojo.usecase.QuestionUseCase
 import io.swagger.v3.oas.annotations.Operation
@@ -22,15 +23,13 @@ class QuestionController(
     @PostMapping
     fun createQuestion(
         @Valid @RequestBody request: QuestionCreateRequest,
-    ): DojoApiResponse<Unit> {
-        questionUseCase.create(
+    ): DojoApiResponse<QuestionId> {
+        return questionUseCase.create(
             QuestionUseCase.CreateCommand(
                 content = request.content,
                 type = request.type,
-                imageUrl = request.imageUrl
+                emojiImageId = request.emojiImageId
             )
-        )
-
-        return DojoApiResponse.success()
+        ).let { DojoApiResponse.success(it.id) }
     }
 }
diff --git a/api/src/main/kotlin/com/mashup/dojo/dto/QuestionDto.kt b/api/src/main/kotlin/com/mashup/dojo/dto/QuestionDto.kt
@@ -1,5 +1,6 @@
 package com.mashup.dojo.dto
 
+import com.mashup.dojo.domain.ImageId
 import com.mashup.dojo.domain.QuestionType
 import io.swagger.v3.oas.annotations.media.Schema
 import jakarta.validation.constraints.NotBlank
@@ -12,8 +13,8 @@ data class QuestionCreateRequest(
     @field:NotNull
     val type: QuestionType,
     @field:NotBlank
-    @Schema(description = "질문 이미지")
-    val imageUrl: String,
+    @Schema(description = "질문 이모지 이미지 id")
+    val emojiImageId: ImageId,
 )
 
 @Schema(description = "질문 등록 bulk 요청")

diff --git a/service/src/main/kotlin/com/mashup/dojo/domain/Question.kt b/service/src/main/kotlin/com/mashup/dojo/domain/Question.kt
@@ -10,7 +10,7 @@ data class Question(
     val content: String,
     val type: QuestionType,
     // Todo 정책 확인하고 이름 확실하게 짓기
-    val imageUrl: String,
+    val emojiImageId: ImageId,
     val createdAt: LocalDateTime,
     val deletedAt: LocalDateTime?,
 )

diff --git a/service/src/main/kotlin/com/mashup/dojo/service/DefaultQuestionService.kt b/service/src/main/kotlin/com/mashup/dojo/service/DefaultQuestionService.kt
@@ -1,5 +1,6 @@
 package com.mashup.dojo.service
 
+import com.mashup.dojo.domain.ImageId
 import com.mashup.dojo.domain.Question
 import com.mashup.dojo.domain.QuestionId
 import com.mashup.dojo.domain.QuestionType
@@ -14,7 +15,7 @@ interface QuestionService {
     fun createQuestion(
         content: String,
         type: QuestionType,
-        imageUrl: String,
+        emojiImageId: ImageId,
     ): Question
 }
 
@@ -25,7 +26,7 @@ class DefaultQuestionService : QuestionService {
     override fun createQuestion(
         content: String,
         type: QuestionType,
-        imageUrl: String,
+        emojiImageId: ImageId,
     ): Question {
         // todo create questionEntity
         // return QuestionRepository.save(content, type, imageUrl).toQuestion
@@ -42,7 +43,7 @@ class DefaultQuestionService : QuestionService {
                 id = QuestionId(8181818),
                 content = "세상에서 제일 멋쟁이인 사람",
                 type = QuestionType.FRIEND,
-                imageUrl = "default:url",
+                emojiImageId = ImageId(1),
                 createdAt = LocalDateTime.now(),
                 deletedAt = null
             )

diff --git a/service/src/main/kotlin/com/mashup/dojo/usecase/QuestionUseCase.kt b/service/src/main/kotlin/com/mashup/dojo/usecase/QuestionUseCase.kt
@@ -1,5 +1,6 @@
 package com.mashup.dojo.usecase
 
+import com.mashup.dojo.domain.ImageId
 import com.mashup.dojo.domain.Question
 import com.mashup.dojo.domain.QuestionType
 import com.mashup.dojo.service.QuestionService
@@ -9,7 +10,7 @@ interface QuestionUseCase {
     data class CreateCommand(
         val content: String,
         val type: QuestionType,
-        val imageUrl: String,
+        val emojiImageId: ImageId,
     )
 
     fun create(command: CreateCommand): Question
@@ -23,7 +24,7 @@ class QuestionCreateUseCase(
         return questionService.createQuestion(
             command.content,
             command.type,
-            command.imageUrl
+            command.emojiImageId
         )
     }
 }