feat: 이미지 로드용 인터페이스를 작성해요 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xonmin
approved these changes
Jun 29, 2024
xonmin
reviewed
Jun 29, 2024
| } | ||
|
|
||
| @Component | ||
| class ImageUseCaseImpl( |
There was a problem hiding this comment.
Impl 를 suffix 로 붙이는 것을 지양하는 것으로 알고 있습니다. https://www.reddit.com/r/androiddev/comments/d05di8/do_you_use_the_impl_suffix_if_you_only_have_one/
Impl 말고 인터페이스와 구현체가 1:1 이라면 prefix 로 Default 로 네이밍 하는게 어떨까 다같이 의논했습니당
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] pr template작업 내용
이미지 로드용 인터페이스 작성. (일단 Mock으로 사용하기!)
비고 (첨부자료)