Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update : add category in question & update Image to sealed class #22

Merged
merged 1 commit into from
Jun 29, 2024
Merged

update : add category in question & update Image to sealed class #22

merged 1 commit into from
Jun 29, 2024

Conversation

xonmin
Copy link
Member

@xonmin xonmin commented Jun 29, 2024 •
edited
Loading

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [add] pr template
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

  • Question λ‚΄ μΉ΄ν…Œκ³ λ¦¬ λΆ„λ₯˜λ₯Ό μœ„ν•΄ QuesitonCategory λ₯Ό μΆ”κ°€ν•©λ‹ˆλ‹€.
  • Image λ₯Ό sealed class 둜 λΆ„λ₯˜ν•˜κ³ , UserImage 와 EmojiImage 둜 μ„ΈλΆ„ν™” ν•©λ‹ˆλ‹€.

λΉ„κ³  (μ²¨λΆ€μžλ£Œ)

@xonmin xonmin self-assigned this Jun 29, 2024
@xonmin xonmin force-pushed the jeongmin/add-category-question branch from 365640b to 5f42e49 Compare June 29, 2024 11:08
@xonmin xonmin merged commit 3d87454 into master Jun 29, 2024
1 check passed
@xonmin xonmin deleted the jeongmin/add-category-question branch June 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonlog-g wonlog-g wonlog-g approved these changes

@yaeoni yaeoni Awaiting requested review from yaeoni yaeoni is a code owner

@toychip toychip Awaiting requested review from toychip toychip is a code owner

Assignees

@xonmin xonmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xonmin @wonlog-g