Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QuestionSheet Scheduler #38

Merged
merged 6 commits into from
Jul 13, 2024
Merged

Conversation

toychip
Copy link
Member

@toychip toychip commented Jul 4, 2024

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [add] pr template
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

QuestionSheet Schedulerλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

λΉ„κ³  (μ²¨λΆ€μžλ£Œ)

@toychip toychip self-assigned this Jul 4, 2024

override fun createQuestionSheet(): List<QuestionSheet> {
val currentQuestionSet = questionService.getCurrentQuestionSet()
val allMemberRecords = memberService.findAllMember()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuestionSet μ—μ„œ Question Id 듀을 μ΄μš©ν•΄μ„œ Question 별 QuestionType μ‘°νšŒν•΄μ˜€κ³ 
MemberService μ—μ„œ MemberId 와 QuestionType 을 λ°›μ•„μ„œ ν›„λ³΄μžλ₯Ό 4~8λͺ… λ½‘μ•„μ˜€κ³ 
Service Layer μ—μ„œλŠ” λ‹€λ₯Έ μ„œλΉ„μŠ€ λ ˆμ΄μ–΄ 호좜이 μ–΄λ ΅λ‹€λ³΄λ‹ˆ,
μœ μ €λ³„ μ–΄λ–€ ν›„λ³΄μžκ°€ μžˆλŠ” 지 ν›„λ³΄μžλ„ λ§žμΆ°μ„œ questionService.createQuestionSheets() 에 λ„˜κ²¨μ€˜μ•Ό ν•  것 같은데 μ–΄λ–€κ°€μš”?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§μ”€ν•˜μ‹  λ‘œμ§μ„ QuestionServiceμ—μ„œ

override fun createQuestionSheets(
    questionSet: QuestionSet?,
    members: List<Member>,
): List<QuestionSheet> {
    /**
     * TODO:
     * target : members
     * question : QuestionSet
     * candidate : member.candidate()
     *
     * - make friend logic, get Candidate logic
     * - cache put -> QuestionSet and return
     * - Temporarily set to create for all members, discuss details later
     */
    return LIST_SAMPLE_QUESTION_SHEET
}

μœ„μ™€ 같이 Candidate와 Question을 QuestionServiceμ—μ„œ μƒμ„±ν•˜λ €ν–ˆλŠ”λ°, QuestionUseCaseμ—μ„œ μƒμ„±ν•˜λŠ” 것이 μ’‹μ„κΉŒμš”??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ…Όμ˜ ν›„ Candidate λ³„λ‘œ Domain 으둜 λΊ„ κ²ƒμœΌλ‘œ κ³„νšν•˜μ˜€μŠ΅λ‹ˆλ‹€.

@toychip toychip mentioned this pull request Jul 7, 2024
4 tasks
@toychip toychip merged commit 38f591b into master Jul 13, 2024
1 check passed
@toychip toychip deleted the junhyoung/add-QuestionSheet-Scheduler branch July 13, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants