-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QuestionSheet Scheduler #38
Conversation
service/src/main/kotlin/com/mashup/dojo/service/QuestionService.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/com/mashup/dojo/service/MemberService.kt
Outdated
Show resolved
Hide resolved
|
||
override fun createQuestionSheet(): List<QuestionSheet> { | ||
val currentQuestionSet = questionService.getCurrentQuestionSet() | ||
val allMemberRecords = memberService.findAllMember() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QuestionSet μμ Question Id λ€μ μ΄μ©ν΄μ Question λ³ QuestionType μ‘°νν΄μ€κ³
MemberService μμ MemberId μ QuestionType μ λ°μμ ν보μλ₯Ό 4~8λͺ
λ½μμ€κ³
Service Layer μμλ λ€λ₯Έ μλΉμ€ λ μ΄μ΄ νΈμΆμ΄ μ΄λ ΅λ€λ³΄λ,
μ μ λ³ μ΄λ€ ν보μκ° μλ μ§ ν보μλ λ§μΆ°μ questionService.createQuestionSheets() μ λ겨μ€μΌ ν κ² κ°μλ° μ΄λ€κ°μ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ§μνμ λ‘μ§μ QuestionServiceμμ
override fun createQuestionSheets(
questionSet: QuestionSet?,
members: List<Member>,
): List<QuestionSheet> {
/**
* TODO:
* target : members
* question : QuestionSet
* candidate : member.candidate()
*
* - make friend logic, get Candidate logic
* - cache put -> QuestionSet and return
* - Temporarily set to create for all members, discuss details later
*/
return LIST_SAMPLE_QUESTION_SHEET
}
μμ κ°μ΄ Candidateμ Questionμ QuestionServiceμμ μμ±νλ €νλλ°, QuestionUseCaseμμ μμ±νλ κ²μ΄ μ’μκΉμ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ Όμ ν Candidate λ³λ‘ Domain μΌλ‘ λΊ κ²μΌλ‘ κ³ννμμ΅λλ€.
[add] pr template
μμ λ΄μ©
QuestionSheet Schedulerλ₯Ό μΆκ°νμ΅λλ€.
λΉκ³ (첨λΆμλ£)