Feat : 초대링크 생성 API 구현, 지도 생성/수정/조회 API 추가 설정 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invite link 생성 API 구현
- invite-link module, service 생성
- map controller에서 invite-link service 호출
- user-map 권한체크를 위한 guard 추가
- 지도 삭제 API는 soft delete vs hard delete 중에 선택이 필요하므로 우선 보류 (mvp 범위아님)
sally0226
commented
Jul 5, 2024
Comment on lines
+22
to
+24
| @Property({ type: 'string', default: UserMapRole.WRITE }) | ||
| @Enum({ items: [UserMapRole.ADMIN, UserMapRole.READ, UserMapRole.WRITE] }) | ||
| map_role: UserMapRoleValueType; |
There was a problem hiding this comment.
invite-link 에 map-role 컬럼을 두어 해당 링크로 지도에 가입할 때, user-map.role에 invite-link.map-role을 넣는 것으로 처리 예정입니다~
map-role기본값 =WRITE
Ho-s
reviewed
Jul 5, 2024
chanwoonglee
reviewed
Jul 5, 2024
- 사용하지 않는 함수 제거 - DTO필드 카멜케이스 변경
Ho-s
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
Key changes
To reviewers
map-role컬럼을 두어 해당 링크로 지도에 가입할 때,map-role을 갖는 것으로 처리 하고 싶었습니다.map-role기본값 =WRITEScreenshots