Feat: Map API 수정 및 맛집 삭제 API, 키워드 저장 로직 추가 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invite link 생성 API 구현
- invite-link module, service 생성
- map controller에서 invite-link service 호출
- user-map 권한체크를 위한 guard 추가
- 지도 삭제 API는 soft delete vs hard delete 중에 선택이 필요하므로 우선 보류 (mvp 범위아님)
- 지도 생성 - 서버에서 id 생성하도록 수정 - 지도 정보 조회 - ui상 필요한 place 개수 return
- 등록된 맛집 삭제 API 추가 - 최근 검색한 키워드 저장 로직 추가
chanwoonglee
changed the title
Ho-s
reviewed
Jul 5, 2024
|
|
||
| @Property({ type: 'string' }) | ||
| @Property({ type: 'string', unique: true }) |
There was a problem hiding this comment.
class validator로 unique 침범하면, 에러 메시지 커스텀하게 보여줄 수 있도록 하는 건 어떨까요?
There was a problem hiding this comment.
오~ 좋은데 한번 해볼게 감사링!
| @@ -38,7 +38,7 @@ export class PlaceForMap { | |||
| }) | |||
| likedUserIds: number[]; | |||
|
|
|||
| @OneToOne(() => User) | |||
| @ManyToOne(() => User) | |||
| @@ -27,7 +28,7 @@ export class CustomExceptionFilter implements ExceptionFilter { | |||
| private readonly utilService: UtilService, | |||
| ) {} | |||
|
|
|||
| async catch(exception: Error, host: ArgumentsHost) { | |||
| async catch(exception: BaseException | Error, host: ArgumentsHost) { | |||
src/auth/strategies/jwt.strategy.ts
Outdated
| id: payload.id, | ||
| }); | ||
| if (!user) { | ||
| throw new UserNotFoundException(); |
There was a problem hiding this comment.
guard에 들어가는 strategy라서 unauth 로 날려주는 게 맞을 거 같은데, 404로 바꾼 이유가 잇을까여?
There was a problem hiding this comment.
오이 jwt strategy에서 토큰이 유효하지 않는 경우는 401로 다 처리하고 있어서,
유효한 토큰에 유저가 없는 경우를 알려줄려고 404로 하고 유저 없다고 에러 메시지로 따로 적었어
401이 맞긴 하겠다 code만 401로 바꿀게!
| @@ -30,6 +30,10 @@ const MikroOrmConfig: Options = { | |||
| entities: entities, | |||
| metadataProvider: ReflectMetadataProvider, | |||
| debug: utilService.isDev(), | |||
| schemaGenerator: { | |||
| disableForeignKeys: true, | |||
There was a problem hiding this comment.
실제 DB에 foreignkey 안생기게 하는 옵션인데, mapID 타입 바꾸다가 constraint 계속 걸려서 화딱지가 나버림
그래서 일단 추가했는데 문제 생길게 있을까 ??
There was a problem hiding this comment.
외래키가 없을 떄 실무에서도 문제된 적 없지? 그때도 얘기 나왔던 거 같은데 그럼 컷!!!
sally0226
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
For what purpose
ui에 맞춘 API 수정 및 MVP 기능 API 추가
Key changes
To reviewers
ui따라 바꿀게 많아서 테스트는 나중에..
Screenshots