-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MASGITOFF (Mastodon Git Optimized File Format) Support #25
Draft
maarzt
wants to merge
32
commits into
master
Choose a base branch
from
masgitoff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing: * spot labels * tags * correct handling of the row index * spot UUID
This commits uses reflection to get access to the otherwise package private ModelSerializer class. The ModelSerializer class is used by the Mastodon core to quickly convert Spots and Links into a series of bytes. And it is essential for good performance during read and write of a Mastodon project.
These improve the readability of the error messages. When tags differ between two model.
Previously an old spot label that after renaming or deleting would not be required anymore was still written in a spot-labels directory.
# Conflicts: # pom.xml
Both classes where copied from github repo: https://github.com/mastodon-sc/mastodon Commit hash: 9caa9c505d152eaf3314c4cf4edfb464ef6d6939 The classes where renamed and minimal changes where made to fix compile errors. Also the class MamutViewStateXMLSerialization in mastodon core needs to be public for this to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #21
TODOs
ProjectLoader
andProjectSaver
classes from mastodon-sc/mastodon and requires theMamutViewStateXMLSerialization
class to be public.ProjectLoader
andProjectSaver
to be copiedMamutViewStateXMLSerialization
would not need to be public any longer.