Let the DefaultObjTagMap return null as tag, if the given object was … #358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when repainting the branch graph.
It occurred in a very specific situation, when:
Visualisation:
![GIF 05 12 2024 11-01-57](https://private-user-images.githubusercontent.com/10515534/392760591-91484752-4ac5-4b93-b770-fb5128cf2304.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODY4MTIsIm5iZiI6MTczODk4NjUxMiwicGF0aCI6Ii8xMDUxNTUzNC8zOTI3NjA1OTEtOTE0ODQ3NTItNGFjNS00YjkzLWI3NzAtZmI1MTI4Y2YyMzA0LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDAzNDgzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE5NGZiMDA3NjNhMTA5NTMwZmU1OGRhMDA1ZDVjOTljOWU0ZTJlN2YyODIzY2VhZWNlYWE1YmNjZjAxMTJmMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.36dSDn5CKjQ2iKC5EmwT6zpHd8_2YW-SuNDxpumcwvs)
Solution:
Comparably easy: let the DefaultObjTagMap return
null
as tag, if the object given to it wasnull