Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context chooser from MamutBranchViewGrapher #362

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

stefanhahmann
Copy link
Collaborator

This PR removes the context chooser from the MamutBranchViewGrapher.

With the current implementation, it produces errors, when contexts other the "full graph" are chose.

Similarly to the MamutBranchViewTrackScheme, the context chooser can currently not really be used in MamutBranchView(s), since the context chooser / the context provider can provide spots, but in the branch view branch spots are required and translation between them is with the current architecture not possible

@stefanhahmann stefanhahmann self-assigned this Dec 19, 2024
@tinevez
Copy link
Contributor

tinevez commented Dec 20, 2024

All good.
Maybe remove the remaining empty 'from context' label:
Screenshot 2024-12-20 at 11 05 18

Lines:
https://github.com/mastodon-sc/mastodon/blob/master/src/main/java/org/mastodon/views/grapher/display/GrapherSidePanel.java#L204-L220

@tinevez
Copy link
Contributor

tinevez commented Dec 25, 2024

Ok maybe I don't get this part right. When I test this PR, it seems that the 'Items to plot' selection is not respected on the branch grapher.

@stefanhahmann stefanhahmann force-pushed the remove-context-chooser branch 3 times, most recently from 5a20575 to 42d01ca Compare January 6, 2025 14:57
* Similarly to the MamutBranchViewTrackScheme, the context chooser can currently not really be used in MamutBranchView(s), since the context chooser / the context provider can provide spots, but in the branch view branch spots are required and translation between them is with the current architecture not possible
@stefanhahmann
Copy link
Collaborator Author

All good. Maybe remove the remaining empty 'from context' label:

I decided to keep this radio button, but rename to the only possible context, i.e. "full graph" in the grapher branch view:

grafik

Without this radio button, there would not be a possibility for the user to go back to "full graph", after e.g. "selection" or "track of selection had been chosen".

@stefanhahmann
Copy link
Collaborator Author

Ok maybe I don't get this part right. When I test this PR, it seems that the 'Items to plot' selection is not respected on the branch grapher.

Thanks for testing and spotting this. My PR indeed destroyed that the selection of 'Items to plot' was respected. I force pushed a change and now this selection is respected again.

@stefanhahmann
Copy link
Collaborator Author

@tinevez I addressed your comments. Can you have a look on this PR again?

@tinevez
Copy link
Contributor

tinevez commented Jan 6, 2025

All good!
Congrats!

@tinevez tinevez merged commit 945da73 into mastodon-sc:dev Jan 6, 2025
1 check passed
@stefanhahmann stefanhahmann deleted the remove-context-chooser branch January 6, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants