Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Japanese translation #29

Closed
wants to merge 4 commits into from
Closed

Update Japanese translation #29

wants to merge 4 commits into from

Conversation

usergreen
Copy link
Contributor

No description provided.

mbkma
mbkma reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@mbkma mbkma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits into one single commit.

content/ja/mate-desktop/applications/engrampa.md

<--->

[![](../images/engrampa-window.png)](../images/engrampa-window.png)
Copy link
Member

@mbkma mbkma Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the images to the static dir (#28). Please replace this with ![](/img/applications/engrampa-window.png)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that concern is open?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbkma Maybe we merge that and fix the link after?

@raveit65 raveit65 mentioned this pull request Feb 3, 2024
Merged
@raveit65
Copy link
Member

raveit65 commented Feb 4, 2024

I used your commits in another PR with the fixed link.
#35
Just merged.....

@raveit65 raveit65 closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbkma mbkma mbkma left review comments

@raveit65 raveit65 raveit65 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usergreen @raveit65 @mbkma