Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tab container from the schema page #4112

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Remove tab container from the schema page #4112

wants to merge 7 commits into from

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Jan 7, 2025 •
edited
Loading

Fixes #4056

Screenshot

Screenshot 2025-01-07 at 8 15 50 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 closed this Jan 7, 2025
@kgodey
Copy link
Contributor

kgodey commented Jan 7, 2025

@Anish9901 don't close this yet, we might want to merge it, I was going to talk to @ghislaineguerin

@Anish9901
Copy link
Member Author

Oh, alright @kgodey, I thought we weren't doing it.

@Anish9901 Anish9901 reopened this Jan 7, 2025
@Anish9901 Anish9901 marked this pull request as ready for review January 7, 2025 17:24
@zackkrida
Copy link
Contributor

I'm just going to draft this until a decision is made on how to proceed.

@zackkrida zackkrida marked this pull request as draft January 7, 2025 19:06
@seancolsen
Copy link
Contributor

seancolsen commented Jan 7, 2025 •
edited
Loading

I think it makes sense to keep this as a draft for now. But I went ahead and took a look anyway.

Your changes looks great, @Anish9901. I did push d538603 to make the routing code follow the patterns used in other files, but I'm not 100% sure that's even necessary in this case. I just wanted to err on the safe side.

The effect of this PR is exactly what I had in mind when I originally opened this issue.

The concern that @ghislaineguerin raised on our call (discussion on this topic began at ~5:40) was that by making this change we'd lose the functionality to filter tables and explorations.

Personally, I don't think we need that functionality. I think simplicity is better in this case. But if we wanted to keep the filter bar, we could stick it below. It just gets a little tricky when filtering explorations because there is less space. So there is potentially some design work or improvisation to take into account if we go that direction.

@Anish9901
Copy link
Member Author

Anish9901 commented Jan 8, 2025 •
edited
Loading

The concern that @ghislaineguerin raised on our call (discussion on this topic began at ~5:40) was that by making this change we'd lose the functionality to filter tables and explorations.

Thanks @seancolsen, That makes sense, I got a lot of insights from that call.

@zackkrida
Copy link
Contributor

We're going to move forward with this change after beta, as there are some additional necessary changes that may take time.

@seancolsen
Copy link
Contributor

Regarding the comments @pavish made during today's meeting:

  • It looks like SchemaExplorations.svelte and SchemaTables.svelte are now dead code that can be removed. @Anish9901 can you delete those files?

  • As for any bugs in functionality. I think we're good here. I've testing when deleting tables and explorations. Redirection works as expected.

I'd like to merge this after the dead code is deleted. Is that okay with you, @pavish?

@Anish9901 Anish9901 marked this pull request as ready for review January 9, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seancolsen seancolsen seancolsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0 (beta release) - nice to haves
Development

Successfully merging this pull request may close these issues.

Remove tabs on schema page
4 participants
@Anish9901 @kgodey @zackkrida @seancolsen